nano-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] enable searching (^W) in a help text (^G)


From: Benno Schulenberg
Subject: Re: [Nano-devel] [PATCH] enable searching (^W) in a help text (^G)
Date: Mon, 19 Dec 2016 11:28:40 +0100

On Sun, Dec 18, 2016, at 15:20, Rishabh Dave wrote:
> In my last patch, I used another way to assign fileage to edittop.

By calling edit_refresh()?  But then you first repaint the screen
at (possibly) the wrong position, then go find the right position,
and then repaint the screen /again/.  What a waste.

Fixed in git in a different way, simply by using a variable that
is already initialized.

> And the other patch replaces name do_up(TRUE) and do_down(TRUE) by
> do_scroll_up() and do_scroll_down() for readability.

Yes, would be good, but... won't compile when configured with
--enable-tiny --enable-help.

Benno

-- 
http://www.fastmail.com - Faster than the air-speed velocity of an
                          unladen european swallow




reply via email to

[Prev in Thread] Current Thread [Next in Thread]