Re: [Nano-devel] [PATCH 07/10] assume regex.h support is always available

[Benno Schulenberg]

On Wed, Feb 22, 2017, at 22:28, Mike Frysinger wrote:
> On 21 Feb 2017 16:12, Mike Frysinger wrote:
> > On 21 Feb 2017 21:12, Benno Schulenberg wrote:
> > > After those ten patches, nano's binary has grown from
> > > 195K to 203K.  Not much, but still: how come?  Eight
> > > kilobytes of code is compiled in that we're not using?
> > 
> > when i test locally, code size is unchanged.

True.  Testing later on a fully up-to-date system, the binaries
before and after the patch series were the exact same size.

> > off the top of my head,
> > i'd guess that gnulib detected some bugs in your system and pulled in
> > fixes/workarounds for them.  just because you're running glibc doesn't
> > mean it's bug free :).
> 
> did you have an opinion on this ?

No.  Just that it sounded like a good explanation of the
perceived difference in size on an older system.  :)

> i'm hesitant to try and do any kind of magic probing.

No, better let it be.  Let gnulib put in whatever it thinks
is necessary.

> i might be able to add a flag like "--disable-gnulib", but i'm not sure
> how useful that'll actually be.

Better not.  If nano is compiled on a system where some
function has a tiny bug (and gnulib provides a faultless
one), we will have to ask on every bug report to stop
using --disable-gnulib.

Benno

-- 
http://www.fastmail.com - A fast, anti-spam email service.