Re: [Nano-devel] [PATCH] allow suppressing the creation of .save files

[Benno Schulenberg]

Op  1-07-2017 om 14:24 schreef Rishabh Dave:
> Renamed NO_SAVEFILE and --nosavefile to NO_DOTSAVE and --nodotsave,
> relocated return statement to die_save_file(), added support for
> rcfile, relocated the code-fragments to more appropriate locations and
> conducted few tests. Patch is attached.

Patch looks good.  Thanks.  Some details:


-    if (ISSET(RESTRICTED))
+    if (ISSET(RESTRICTED) || ISSET(NO_DOTSAVE))
        return;

Nice.  You made use of what was already there.  Good.

-    NO_PAUSES
+    NO_PAUSES,
+    NO_DOTSAVE

You will have to rebase/adjust the patch when the varisoft branch
has been merged (within a week or so), because that one adds an
option too.

     {"nohelp", NO_HELP},
+    {"nodotsave", NO_DOTSAVE},
     {"nonewlines", NO_NEWLINES},
     {"nopauses", NO_PAUSES},

Not entirely alphabetical, but I admit it looks better this way.
Good.

When the varisoft branch has been merged, adjust your patch,
commit it, with an appropriate message and sign-off, and then
attach it to the relevant request on Savannah.  Then we'll see.

Benno