[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nano-devel] [PATCH] bug #48501: [Request] add the ability to paste
From: |
Rishabh Dave |
Subject: |
Re: [Nano-devel] [PATCH] bug #48501: [Request] add the ability to paste at the prompt |
Date: |
Mon, 24 Jul 2017 02:28:35 +0530 |
> No. But mention the request on Savannah that it fulfills.
Done.
> Now to the patch:
>
> + add_to_sclist((MMOST & ~MBROWSER & ~MLINTER & ~MSPELL) | MYESNO,
> + "^U", 0, do_uncut_text, 0);
> + add_to_sclist((MMOST & ~MBROWSER & ~MLINTER & ~MSPELL) | MYESNO,
> + "F10", 0, do_uncut_text, 0);
>
> You correctly exclude the browser and linter menus. But why do you
> exclude the (internal) speller menu? Of course: it will be highly
> unlikely that someone wants to replace a misspelled word with something
> from the cutbuffer, but why forbid it? And why do you include the
> Yes-No menu? Nothing can be pasted there, no text can be input, one
> can only type Y or N or A (or their translations) or ^C. Further,
> you don't exclude the help menu. But that doesn't matter: it is not
> necessary to exclude the browser and linter menus either because they
> simply ignore the Uncut function. Or did you exclude them with a
> reason?
Changed those lines to include nothing but MMOST.
> The rest of the patch looks okay. Although: it's not necessary to
> initialize fusion to NULL
Just part of habit, helps prevent silly, time consuming bugs. Removed
initialization.
0001-new-feature-enable-uncut-at-all-prompts.patch
Description: Text Data