Re: [Nano-devel] [PATCH] Indicate open buffer count in title bar

[Benno Schulenberg]

Op 31-08-2017 om 18:45 schreef Marco Diego Aurélio Mesquita:
> On Tue, Aug 29, 2017 at 4:29 PM, Benno Schulenberg <address@hidden> wrote:
> > Interesting.  It doesn't work correctly yet, though: when you have
> > just opened three files and then hit ^X, it will switch to the next
> > buffer but it will still say: [2/3].  Only after a ^L will it say
> > [1/2].
>
> I'm not sure why this happens. Maybe it is because the buffer is only
> removed after it is switched.

Correct.

> I think forcing a screen update whenever
> a buffer is removed can fix this.

In close_buffer, after unlink_opennode(), you will have to add a call
to titlebar(NULL).  Also, make sure that [x/y] is not shown when inhelp
is TRUE (press ^G to see what I mean).

> The firstfile global variable may need to be update
> whenever a buffer is closed. Can you point me in the code where this
> happens?

In close_buffer() in src/files.c.

> > For it to get accepted, there will have to be some response from
> > other people, saying that they like and want this feature.
>
> How can I get people to say so?

As you may have seen, there is no need to.  :)  Enough people have
said that they like the feature.  So it will go in when the patch
is ready and good.  Make sure to sign it off when you are ready,
sending in a proper git patch.

Benno