[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nano-devel] [PATCH] history: remember the commands that were execut
From: |
Benno Schulenberg |
Subject: |
Re: [Nano-devel] [PATCH] history: remember the commands that were executed during this session |
Date: |
Fri, 15 Sep 2017 22:08:23 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
[Please stop sending me email. Send it only to the list. (The patch was CC'ed
to you because that is what git does: you were the author, so you should know
when the patch is sent somewhere. In all other cases, just send your emails to
the list. I don't want copies in my inbox.]
Op 15-09-2017 om 01:06 schreef Marco Diego Aurélio Mesquita:
Please, consider the attached patch.
execute_command(answer);
update_history(&execute_history, answer);
+ history_changed = TRUE;
There is no need to set history_changed, because update_history() already
does that. And thus there is no need to make that variable global:
+bool history_changed = FALSE;
+ /* Have any of the history lists changed? */
I do see now that history_changed should be set to FALSE at the end of
load_history(). (But don't do that in your patch -- it is a separate
issue. I'll fix that later by moving all history stuff to a new file.)
Benno