nano-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] Implement incremental search v2


From: Benno Schulenberg
Subject: Re: [Nano-devel] [PATCH] Implement incremental search v2
Date: Wed, 1 Nov 2017 21:26:17 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0


Op  1-11-2017 om 08:01 schreef Marco Diego Aurélio Mesquita:
The attached patch implements incremental search for nano. It fixes a
problem when used with regexes.

I must say it looks pretty cool.  But when having typed a couple
of letters, I get the urge to type M-W to make the highlight jump
to the next occurrence.  :|

Please review it.

I don't have time for this.  But two things: your patch makes a
mess of the help lines in the Search menu -- keep related things
paired.  (But you can do that in a second patch.)  When inserting
a line of code, don't just place it anywhere, do it with reason
and consistency -- a new option never gets inserted at the top.

Benno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]