Re: [Nano-devel] [PATCH] small addition: understand color name "normal" to mean the default color

[Benno Schulenberg]

Op 30-03-18 om 11:34 schreef Brand Huntsman:
> Benno Schulenberg <address@hidden> wrote:
>> I think it should handle both cases the same.  I think it makes the
>> most sense to reject a color command whenever something is wrong with
>> it.  So I have pushed a change that does that: commit cbf22647.
> 
> Ya, I sent a patch a month ago to fix that.

I don't look at all of your patches.  When you swamp me, I drop it all
on the floor.

> http://lists.gnu.org/archive/html/nano-devel/2018-03/txt3TUQ80c18P.txt

I skipped that patch after reading: Prevents "black,redd" from causing...
(Is that a typo?  Am I supposed to understand that that is an example?
Hrrm!  Bad commit message.  Skip.)

> The -2 check should happen before the bright background check.

No.  When for example "brightonion" is given, I want to see both
complaints: about the onion and about the bright.

> A returned error should be handled before any return value validations.

The *bright will always be set when color_to_short() returns.

> And why did you remove the comment on invalid fg check?

The comment moved to the function's header.

Benno

signature.asc
Description: OpenPGP digital signature