Re: [Nano-devel] [PATCH V6] Implement bookmarks

[David Ramsey]

Benno Schulenberg:
> Geany's bookmarks just remember a line; when you jump to such a
> bookmark, the cursor jumps to the start of the line.  Does nano need
> more precision than that?

<snip>

> No.  When people have such long lines that they need a bookmark in order
> to navigate inside it, they... deserve their misery.  They will have to
> type <Alt+PageUp> and then <Alt+PageDown> to jump to that mark.

Brand Huntsman:
> ...changing bookmark_x to a bool and only jumping to start of line, as
> Benno suggested, would solve the need to not ignore current line or
> move a bookmark. Less useful for softwrapped paragraphs but it
> eliminates all confusion.

Thirded on both counts.  Jumping to the start of the line is precise
enough for me, and if a single softwrapped line is long enough to need
multiple bookmarks on it, that's what search is for.

(Alternatively, you could just justify overly long lines with --fill=72
to break them up into pieces, edit the pieces using bookmarking, and
then justify the pieces again with --fill=100000 to turn them back into
overly long lines.  Assuming that the lines are no longer than 100000
columns, of course.)

Having multiple bookmarks is fine and, in many cases, necessary; having
multiple bookmarks *per line* and having to move them around is overly
complex.

----------

Benno Schulenberg:
> Do you have any plans to make them visible?

I wonder about this too; seeing where bookmarks are would be handy.

<snip>

> Searching for a bookmark should not stop at top or bottom of file,
> it should wrap around, like ^W does.

Seconded; that would make it consistent.

----------

I've noticed one oddity in the first patch: relevant functions are named
bookmark(), bookmark_next(), bookmark_previous(), etc., but there's one
that breaks the pattern: go_to_book_mark().  Shouldn't it be named
go_to_bookmark() instead, so that searching for "bookmark" doesn't miss
it?