[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nano-devel] [PATCH 1/2 V3] cutting: when ^K does not actually cut a
|
From: |
David Ramsey |
|
Subject: |
Re: [Nano-devel] [PATCH 1/2 V3] cutting: when ^K does not actually cut anything, do not add an undo item |
|
Date: |
Mon, 31 Dec 2018 12:37:55 -0600 |
These mostly look good, although I haven't been able to actually test
them yet. However, there are a few nits:
1. In patch 0001. in nothing_needs_cutting() and do_cut_till_eof(), you
have the check:
openfile->current->next == NULL
Wouldn't the check:
openfile->current == openfile->filebot
be simpler, clearer as to what it's doing, and accomplish the same
thing?
2. In patch 0002, the messages "Nothing was cut" and "The cutbuffer is
empty" seem inconsistent, given that cut and uncut/paste are supposed to
be inverses of each other. Maybe use "Nothing to cut" and "Nothing to
uncut", or something similar?