[Net::FTPServer] Fwd: Net::FTPServer patches proposal

[Richard Jones]

----- Forwarded message -----

Subject: Net::FTPServer patches proposal
From: Marek ?awicki <address@hidden>
To: address@hidden
Organization: SAFO sp. z o.o.

Hi,

I think I've found a bug in Net::FTPServer (1.120)  which prevents from
logging in client log.
First two patches eliminate warnings in error log.

--- FTPServer.pm.org    Fri Apr 23 06:07:15 2004
+++ FTPServer.pm        Wed May  5 13:46:26 2004
@@ -3149,7 +3149,8 @@
     my $self = shift ;
     if ( my $log_file = $self->config("xfer logging") ) {
       $log_file = $self->resolve_log_file_name($log_file) ;
-      if ( $log_file ne $self->{_xfer_file} ) {
+      if (!defined $self->{_xfer_file} ||
+           $log_file ne $self->{_xfer_file} ) {
        if ( my $io = $self->{_xferlog} ) {
          $io->close ;
          delete $self->{_xferlog} ;
@@ -3173,7 +3174,8 @@
     my $self = shift ;
     if ( my $log_file = $self->config("client logging") ) {
       $log_file = $self->resolve_log_file_name($log_file) ;
-      if ( $log_file ne $self->{_client_file} ) {
+      if (!defined $self->{_client_file} ||
+           $log_file ne $self->{_client_file} ) {
        if ( my $io = $self->{_client_log} ) {
          $io->close ;
          delete $self->{_client_log} ;
@@ -3207,9 +3209,9 @@
 sub _log_line
   {
     my $self = shift;
-    return unless exists $self->{client_log};
+    return unless exists $self->{_client_log};
     my $message = join ("",@_);
-    my $io = $self->{client_log};
+    my $io = $self->{_client_log};
     my $time = scalar localtime;
     my $authenticated = $self->{authenticated} ? $self->{user} : "-";
     $message =~ s/\n*$/\n/;


I hope this helps.
I think FTPServer is very good app, thanks for your efforts.

Regards,
-- 
Marek ?awicki
SAFO sp. z o.o.
(0-81) 7458888 w. 009


----- End forwarded message -----

-- 
Richard Jones. http://www.annexia.org/ http://www.j-london.com/
Merjis Ltd. http://www.merjis.com/ - improving website return on investment
If I have not seen as far as others, it is because I have been
standing in the footprints of giants.  -- from Usenet