[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Netutils-dev] [PATCH] Merging BSD backend into one file.
From: |
Debarshi Ray |
Subject: |
Re: [Netutils-dev] [PATCH] Merging BSD backend into one file. |
Date: |
Tue, 7 Oct 2008 02:10:43 +0530 |
> 0001-2008-09-30-Ashish-Shukla-wahjava-gmail.com.diff
Committed and pushed.
> 0002-2008-10-01-Ashish-Shukla-wahjava-gmail.com.diff
This part is problematic since it affects the more common use case of
IPv4 addresses adversely. However I agree that we must do something to
handle show IPv6 addresses elegantly too.
@@ -403,7 +411,7 @@ void
show_route_header (void)
{
puts ("Kernel network routing table");
- printf ("%-15s %-17s %-15s %-5s %-6s %-5s %-5s %-5s\n",
+ printf ("%-40s %-40s %-40s %-5s %-6s %-5s %-5s %-5s\n",
"Destination",
"Gateway",
"Netmask",
@@ -450,7 +458,7 @@ show_netstat_info (const route_info_t * const route_info)
void
show_route_info (const route_info_t * const route_info)
{
- printf ("%-15s %-17s %-15s %-5s %-6"PRIu32" %-5"PRIu32" %-5"PRIu32" %-5s\n",
+ printf ("%-40s %-40s %-40s %-5s %-6"PRIu32" %-5"PRIu32" %-5"PRIu32" %-5s\n",
route_info->dest,
route_info->gateway,
route_info->dest_mask,
I have committed the other changes in this patch.
I took the liberty of sorting out a few coding style related issues.
Will look into the other patches now.
Happy hacking,
Debarshi