Re: [Netutils-dev] [PATCH] Merging BSD backend into one file.

[Ashish Shukla आशीष शुक्ल]

Debarshi Ray writes:
>> 0003-2008-10-05-Ashish-Shukla-wahjava-gmail.com.diff
>> 
>> @@ -236,8 +239,8 @@ bsd_parse_msg (const sa_family_t sa_family,
>> * NOTE: the length will be dynamic as this is a netmask represented in a 
>> sockaddr.
>> */
>> s_len -= (sa_family == AF_INET) ?
>> -               (socklen_t)((char*)(&((struct 
>> sockaddr_in*)sock_addr)->sin_addr) - (char*)sock_addr):
>> -               (socklen_t)((char*)(&((struct 
>> sockaddr_in6*)sock_addr)->sin6_addr) - (char*)sock_addr);
>> +               (socklen_t)((char*)s_addr - (char*)sock_addr):
>> +               (socklen_t)((char*)s_addr - (char*)sock_addr);
>> }
>> 
>> bsd_conv_addr_to_name ((struct sockaddr *) buffer,

> Is the ternary operator needed? s_len is being decremented by
> `(socklen_t) ((char *) s_addr - (char *) sock_addr)' in both cases.

Heh sorry for that silly mistake. Please accept this new diff.

Ashish
-- 
()  ascii ribbon campaign - against HTML e-mail
/\  www.asciiribbon.org   - against proprietary attachments
·-- ·- ···· ·--- ·- ···- ·- ·--·-· --· -- ·- ·· ·-·· ·-·-·- -·-· --- --
% dig +short cname cdac.in @::1
ms.gov.in

0001-2008-10-07-Ashish-Shukla-wahjava-gmail.com.diff
Description: differences between master and my-trunk

pgpRiDZf0cZR9.pgp
Description: PGP signature