[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nmh-workers] whatnow brittle wrt. $SHELL
From: |
David Levine |
Subject: |
Re: [Nmh-workers] whatnow brittle wrt. $SHELL |
Date: |
Sun, 22 Jul 2012 20:13:34 -0500 |
az wrote:
> but: /bin/bash itself does set SHELL, so if it's involved
> you'll have next to no chance of seeing this scenario.
That's it, thanks.
> the nmh code tries to be "nice and helpful" and work with
> the user's preferred shell, so we certainly waste
> some cycles with /bin/sh -c whatevershell -c ...actual stuff...
>
> personally i don't think that aiming for the users' preferred
> shell is necessary for the not-very-interactive situation
> with whatnow, so the $SHELL -c code should indeed be dumped
> in the long run.
On second thought, I use bash-isms when looking for and
adding attachments.
I suppose we could only prepend the "$SHELL -c" if $SHELL is
not equivalent to /bin/sh, but I don't think it's worth the
bother.
David