[Nmh-workers] message corruption with inc

[Paul Fox]

i'm sometimes seeing a minor corruption of incoming mail after running
inc.  it's happened since i switched recently to running latest git
HEAD.

i've bisected, and the first failing commit is:

    commit f6e6ec96c9e179f7817fca4c8c22bc2bd4e417e8 (master~193^2~6^2~31)
    Author: David Levine <address@hidden>
    Date:   Sun Jan 13 11:08:28 2013 -0600

        Added bytes_read to m_getfld() buffer state.  This is the
        next step in supporting ftell()/fseek().


to reproduce:  save the attached message to /tmp/foo.mbox, and run:

    $ inc -file /tmp/foo.mbox
    $ diff -u /tmp/foo.mbox $(mhpath cur)
    --- /tmp/foo.mbox       2013-04-15 11:05:14.000000000 -0400
    +++ /home/pgf/Mail/foo/10       2013-04-15 11:06:24.000000000 -0400
    @@ -1,4 +1,3 @@
    -From address@hidden  Mon Apr 15 00:24:09 2013
     Return-Path: <address@hidden>
     X-Original-To: address@hidden
     Delivered-To: address@hidden
    @@ -37,6 +36,8 @@
     Content-Type: multipart/alternative;
            boundary="b1_b24c20bb119a0a0f754067dd12b0d2c3"
     
    +2c3"
    +
     
     --b1_b24c20bb119a0a0f754067dd12b0d2c3
     Content-Type: text/plain; charset="UTF-8"
    @@ -53,4 +54,3 @@
     
     
     --b1_b24c20bb119a0a0f754067dd12b0d2c3--
    -


you can see that the last several characters of the message header
have been prepended to the message body.  this is the typical behavior
i've been seeing.  never more than 4 or 5 extra characters.

i'll debug if no one else can get to it near-term, but i'm sure david
will be quicker at it than i will be, if he has time.

paul
----------------------
 paul fox, address@hidden (arlington, ma, where it's 47.5 degrees)

>From address@hidden  Mon Apr 15 00:24:09 2013
Return-Path: <address@hidden>
X-Original-To: address@hidden
Delivered-To: address@hidden
Received: from colo.foxharp.net (grass [127.0.0.1])
        by grass.foxharp.boston.ma.us (Postfix) with ESMTP id 7ABAB2E8017
        for <address@hidden>; Mon, 15 Apr 2013 00:24:09 -0400 (EDT)
Received: from mx-out.facebook.com (outmail018.snc7.facebook.com 
[69.171.232.152])
        by colo.foxharp.net (Postfix) with ESMTP id 649D254103
        for <address@hidden>; Mon, 15 Apr 2013 00:17:17 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=facebookmail.com;
        s=s1024-2011-q2; t=1365999848;
        bh=E4JnVGi6ZBizni9cA1lkDgiVmRBIzwfhrt/Fdl3ZgSg=;
        h=Date:To:From:Subject:MIME-Version:Content-Type;
        b=WIbBRu9Clz4KVFnblllkxl8UmkdwdT8LKc4hyIJ1L7+1jCTbFNZUjhS1eFD6qb8/m
         xL7hvRjVGubQ177ZumKOwd5UQ/PhvCdv3cTuxYjebNouSxmvSY8SFmCjuBGooTbGkS
         PKNjKJQKaGI6NOyp661Bx7Rq5XmwQJyMyuUguof0=
Received: from [10.74.228.23] ([10.74.228.23:38708])
        by smout030.snc7.facebook.com (envelope-from <address@hidden>)
        (ecelerity 3.5.1.37927 r(/root/Momo-dev:tip)) with ECSTREAM
        id 1D/AC-06532-8E08B615; Sun, 14 Apr 2013 21:24:08 -0700
X-Facebook: from zuckmail ([MTI3LjAuMC4x]) 
        by www.facebook.com with HTTP (ZuckMail);
Date: Sun, 14 Apr 2013 21:24:08 -0700
To: Paul Fox <address@hidden>
From: "Facebook" <address@hidden>
Reply-to: Reply to Comment <address@hidden>
Subject: Some Friend mentioned you on Facebook
Message-ID: <address@hidden>
X-Priority: 3
X-Mailer: ZuckMail [version 1.00]
Errors-To: address@hidden
X-Facebook-Notify: comment_mention; mailid=xxxxxxxxxxxxx62fG5766f48Gb7
X-FACEBOOK-PRIORITY: 0
X-Auto-Response-Suppress: All
MIME-Version: 1.0
Content-Type: multipart/alternative;
        boundary="b1_b24c20bb119a0a0f754067dd12b0d2c3"


--b1_b24c20bb119a0a0f754067dd12b0d2c3
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

.....


--b1_b24c20bb119a0a0f754067dd12b0d2c3
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable




--b1_b24c20bb119a0a0f754067dd12b0d2c3--