Re: [Nmh-workers] dot locking broken?

[David Levine]

Marcin wrote:

> First, looks like that MAILGROUP=1 does not get set in the config.h
> because we no longer use "LOCKTYPE" configure variable.  This way
> "inc" is also not installed setgid mail.
>
> This is fixed by:
>
> diff --git a/configure.ac b/configure.ac index 02f0a04..158255f

> Let's first fix the error message:
>
> diff --git a/sbr/lock_file.c b/sbr/lock_file.c index

I applied those two patches and committed, thanks.

> Once this is fixed, inc fails to lock my spool: (those messages
> appear in 1 sec intervals as we "wait" to obtain the lock)

It works for me on Linux.  Your ls -l shows that your inc is
setgid mail.  Should setgid work on FreeBSD?  I saw your explanation
but haven't digested it.

> I think that when m_mktemp() fails we should fail with adios(),
> since there is no way things get magically better by waiting.

In this case, it gives up after 3 seconds, which I think is fine.  
As Ken noted, there are more general considerations.  One example
of where waiting could make a difference is when trying to acquire
a lock in /tmp, when it's full.

> I was also wondering if we should give the user to abort waiting for
> a lock with ^C.

I tried, and ^C works for me (on Linux).

David