nmh-workers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nmh-workers] mhfixmsg on a pathological mail


From: Ken Hornstein
Subject: Re: [Nmh-workers] mhfixmsg on a pathological mail
Date: Wed, 30 Aug 2017 11:23:47 -0400

>Well, that's the parsing side;  making the `/subtype' optional.  But the
>above comment suggests RFC-violating `Content-Type: text' would arrive
>from ATTMail when they sent to internet!nongnu.org!nmh-workers.

Sure, but ... I'm still trying to understand the difference in this code
between a zero-length string and NULL.  Maybe this is lost in the mists
of time.

>> Sigh.  I think maybe ripping that bypass for the missing subtype would
>> be best.  Other thoughts?
>
>There's three cases of /ci_subtype.*ci_subtype/ in the source.
>mhfixmsg.c's allows for it to be NULL.  The other two could easily do so
>too.  That would seem the easiest fix without needing to figure out all
>the ways it could be reached.

That seems okay.

>I don't think this is a 1.7 thing;  it's been there years already and
>1.8 will be RSN.

Well, looks like to me that if you feed mhbuild bad input, there is a core
dump.  That seems like a problem worth fixing for 1.7

--Ken



reply via email to

[Prev in Thread] Current Thread [Next in Thread]