nmh-workers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nmh-workers] proposed patch for shell metacharacter failure in nmh-


From: Ken Hornstein
Subject: Re: [Nmh-workers] proposed patch for shell metacharacter failure in nmh-1.7
Date: Mon, 15 Jan 2018 00:26:13 -0500

>> That's not right, it should be:
>>
>>      while ((pp = strchr (pp, '\''))&&  buflen>  3) {
>
>pointers aren't booleans. in BSD style as used in BIND, this would be:
>
>while ((pp = strchr(pp, '\'')) != NULL && buflen > 3) {

Forgive my stupidity ... but this is just a matter of style, correct?
AFAIK, there is no problem from a language perspective.  If there is a
problem from the language perspective, I would like to understand it.

(I am neutral on the style issue, myself).

--Ken



reply via email to

[Prev in Thread] Current Thread [Next in Thread]