[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [OATH-Toolkit-help] fix check for pskctool -h output
From: |
Simon Josefsson |
Subject: |
Re: [OATH-Toolkit-help] fix check for pskctool -h output |
Date: |
Thu, 10 Jan 2013 15:30:13 +0100 |
User-agent: |
Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux) |
Christian Hesse <address@hidden> writes:
> Simon Josefsson <address@hidden> on Thu, 2013/01/10 14:57:
>> Christian Hesse <address@hidden> writes:
>>
>> > Hello everybody,
>> >
>> > check for pskctool -h output fails for me. The attached patch fixes that
>> > for me.
>>
>> Which gengetopt version are you using?
>
> gengetopt 2.22.6-1, build from Arch Linux User Repositories:
> https://aur.archlinux.org/packages/gengetopt/
Ah. I'm using 2.22.5.
>> Since the selfcheck compares
>> output that is generated by gengetopt, I suspect the difference is
>> caused by using different gengetopt versions. Could you try the patch
>> below instead? It removes trailing newlines from the generated file.
>
> No, that one is bad. The problem is not gengetopt generating trailing
> whitespaces (not newlines) but your test file already having trailing
> whitespaces it should not.
Both pathes are needed -- my gengetopt version generate that whitespace.
I have pushed both patches now, can you test?
Thanks,
/Simon