[Octave-bug-tracker] [bug #29553] missing arpack: make check segfaults on eigs

[John W. Eaton]

Follow-up Comment #20, bug #29553 (project octave):

The test code doesn't recognize "%! shared".  There can be no space between
the "%!" and the "shared" keyword.

If you write

  %!testif FOO
  %!shared
  %! ...

this is just saying that there is an empty test block that is executed if FOO
is "true", followed by a block of statements that are to be shared by any
following tests.  So the statements in the shared block are still executed.

The "testif" directive is not just a conditional, but also introduces a test
block.  If you lump them all together, you will only see one failure no matter
how many asserts are triggered.  It will make it much harder to determine
precisely which assert statement failed.

Note that there is a difference between

  %!testif FOO
  %! assert (cond)
  %! assert (cond)

and

  %!assert (cond)
  %!assert (cond)

The first is a single test with two assertions.  The second is a set of two
tests.

Yes, the syntax for inline tests is rigid and imperfect, but I don't think it
is worth a lot of effort to fix these things.  Is there really any harm in
computing a few values even if they are not actually needed?

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?29553>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/