[Octave-bug-tracker] [bug #32756] Ignore unknown datatypes in HDF5 files but load remainder of file correctly

[Daniel Davis]

URL:
  <http://savannah.gnu.org/bugs/?32756>

                 Summary: Ignore unknown datatypes in HDF5 files but load
remainder of file correctly
                 Project: GNU Octave
            Submitted by: ddesics
            Submitted on: Sat 12 Mar 2011 03:20:03 PM GMT
                Category: None
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Improvement/Optimization
                  Status: None
             Assigned to: None
         Originator Name: Daniel Davis
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 3.4.0
        Operating System: GNU/Linux

    _______________________________________________________

Details:

Currently, when octave encounters an unknown datatype in an HDF5 file, it
fails to load the file.

For an example, try loading the attached bug.h5 with

load bug.h5  

The file fails to load.

A patch is attached which fixes this, so that octave will emit a warning
stating that it can't identify the data type and is skipping the specified
variable.  Octave will then proceed to load the portions of the file which it
can identify.

Copying the hdf5_make_range_type function from ov-range.cc is an ad-hoc hack
and something better can certainly be done, but I didn't dig into octave's
code to see how best to access the function from ls-hdf5.cc

I eventually intend to try to pull something together to let octave read
structured data types from hdf5 files, but this is a temporary fix that will
allow octave to read more non-octave created hdf5 files until that time,
without affecting octave created files.

The file test.h5 is a test to verify that I did not break octave's loading of
ranges, since I changed that section of code.  It should load a variable named
val which has a vector going from 1 to 15 in increments of 1.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sat 12 Mar 2011 03:20:03 PM GMT  Name: bug.h5  Size: 157kB   By: ddesics
Bug testing file and patch.
<http://savannah.gnu.org/bugs/download.php?file_id=22908>
-------------------------------------------------------
Date: Sat 12 Mar 2011 03:20:03 PM GMT  Name: hdf5-patch  Size: 2kB   By:
ddesics
Bug testing file and patch.
<http://savannah.gnu.org/bugs/download.php?file_id=22909>
-------------------------------------------------------
Date: Sat 12 Mar 2011 03:20:03 PM GMT  Name: test.h5  Size: 5kB   By: ddesics
Bug testing file and patch.
<http://savannah.gnu.org/bugs/download.php?file_id=22910>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?32756>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/