octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #33625] filter with dimension and empty SI doe


From: Sebastien
Subject: [Octave-bug-tracker] [bug #33625] filter with dimension and empty SI does return error
Date: Thu, 23 Jun 2011 07:19:02 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.9.2.18) Gecko/20110615 Ubuntu/10.04 (lucid) Firefox/3.6.18

Follow-up Comment #1, bug #33625 (project octave):

I have tried that change, and this seems to work:
It now returns the correct result. It passes all the tests and the examples in
bug#32741

Regards,

Seb

--- filter.cc.original  2011-06-22 21:12:35.375952955 +0200
+++ filter.cc   2011-06-23 08:57:30.000000000 +0200
@@ -98,12 +98,6 @@
       return y;
     }
 
-  if (si_dims.length () != x_dims.length ())
-    {
-      error ("filter: dimensionality of SI and X must agree");
-      return y;
-    }
-
   octave_idx_type si_dim = 0;
   for (octave_idx_type i = 0; i < x_dims.length (); i++)
     {
@@ -113,11 +107,6 @@
       if (x_dims(i) == 1)
         continue;
 
-      if (si_dims(++si_dim) != x_dims(i))
-        {
-          error ("filter: dimensionality of SI and X must agree");
-          return y;
-        }
     }


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?33625>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]