[Octave-bug-tracker] [bug #33988] tar erroneously complains about it's arguments

[Orion Poplawski]

URL:
  <http://savannah.gnu.org/bugs/?33988>

                 Summary: tar erroneously complains about it's arguments
                 Project: GNU Octave
            Submitted by: opoplawski
            Submitted on: Thu 11 Aug 2011 04:58:20 PM GMT
                Category: Libraries
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Other
                  Status: None
             Assigned to: None
         Originator Name: opoplawski
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 3.4.2
        Operating System: Any

    _______________________________________________________

Details:

Trying to package up octave package for 3.4.2 and getting:

octave -H -q --no-site-file --eval 'pkg build '\''-verbose'\''
/var/tmp/octave-image-1.0.14-2.fc17.x86_64
/builddir/build/BUILD/image-1.0.14'
warning: creating build directory /var/tmp/octave-image-1.0.14-2.fc17.x86_64
graycomatrix.cc: In function 'octave_value_list Fgraycomatrix(const
octave_value_list&, int)':
graycomatrix.cc:98:30: warning: 'Array<T>::Array(octave_idx_type, const T&)
[with T = int, octave_idx_type = int]' is deprecated (declared at
/usr/include/octave-3.4.2/octave/../octave/Array.h:179)
[-Wdeprecated-declarations]
make: Entering directory `/builddir/build/BUILD/image-1.0.14/src'
mkoctfile -Wall __spatial_filtering__.cc
mkoctfile -Wall __bilateral__.cc
mkoctfile -Wall __custom_gaussian_smoothing__.cc
mkoctfile -Wall __boundary__.cc
mkoctfile -Wall bwlabel.cc
mkoctfile -Wall bwfill.cc
mkoctfile -Wall rotate_scale.cc
mkoctfile -Wall hough_line.cc
mkoctfile -Wall graycomatrix.cc
mkoctfile -Wall deriche.cc
mkoctfile -Wall __bwdist.cc
mkoctfile -Wall nonmax_supress.cc
make: Leaving directory `/builddir/build/BUILD/image-1.0.14/src'
copyfile /builddir/build/BUILD/image-1.0.14/src/__bilateral__.oct
/builddir/build/BUILD/image-1.0.14/src/__boundary__.oct
/builddir/build/BUILD/image-1.0.14/src/__bwdist.oct
/builddir/build/BUILD/image-1.0.14/src/__custom_gaussian_smoothing__.oct
/builddir/build/BUILD/image-1.0.14/src/__spatial_filtering__.oct
/builddir/build/BUILD/image-1.0.14/src/bwfill.oct
/builddir/build/BUILD/image-1.0.14/src/bwlabel.oct
/builddir/build/BUILD/image-1.0.14/src/deriche.oct
/builddir/build/BUILD/image-1.0.14/src/graycomatrix.oct
/builddir/build/BUILD/image-1.0.14/src/hough_line.oct
/builddir/build/BUILD/image-1.0.14/src/nonmax_supress.oct
/builddir/build/BUILD/image-1.0.14/src/rotate_scale.oct
/builddir/build/BUILD/image-1.0.14/inst/x86_64-redhat-linux-gnu-api-v45+
error: tar: all arguments must be character strings
error: called from:
error:   /usr/share/octave/3.4.2/m/miscellaneous/tar.m at line 46, column 5
error:   /usr/share/octave/3.4.2/m/pkg/pkg.m at line 1236, column 7
error:   /usr/share/octave/3.4.2/m/pkg/pkg.m at line 602, column 5
error:   /usr/share/octave/3.4.2/m/pkg/pkg.m at line 471, column 7

This appears to have been caused by the change set 12500:8f2056646dba which
changed:

-    if (ischar (tarfile) && iscellstr (files) && ischar (root))
-
-      cmd = sprintf ("tar cvf %s -C %s %s", tarfile, root,
-                     sprintf (" %s", files{:}));
....

to:

+  if (ischar (tarfile) && iscellstr (files) && ischar (root))
+    error ("tar: all arguments must be character strings");
+  endif

Which completely reversed the logic.  I think you need:

+  if !(ischar (tarfile) && iscellstr (files) && ischar (root))
+    error ("tar: all arguments must be character strings");
+  endif






    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Thu 11 Aug 2011 04:58:20 PM GMT  Name: octave-tar.patch  Size: 437B  
By: opoplawski

<http://savannah.gnu.org/bugs/download.php?file_id=23787>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?33988>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/