[Octave-bug-tracker] [bug #33625] filter with dimension and empty SI does return error

[Oscar Yanez]

Follow-up Comment #11, bug #33625 (project octave):

Sure. This has been quite instructive for me. Sorry for taking time from your
day. 
Let me point out that I added a printf("debug note...") statement to the
filter.cc file before building so that I could show you what I mentioned
before.

Here it goes:

1) Octave 3.4.3 stable, patched with the patch in this thread (the error comes
out, and please observe si_dims(0)).

octave:1> version
ans = 3.4.3
octave:2> y = filter(ones(1,6)/6,1,randn(1000,1),zeros(5,1));
debug note: si_dims(0) = 1
error: filter: first dimension of SI must be of length max (length (a), length
(b)) - 1
octave:2> y = filter(ones(1,6)/6,1,randn(1000,1),zeros(1,5));
debug note: si_dims(0) = 1
error: filter: first dimension of SI must be of length max (length (a), length
(b)) - 1

2) Octave 3.4.3 stable, with the patch and the extra fix I had mentioned
(charm):

octave:1> version
ans = 3.4.3
octave:2> y = filter(ones(1,6)/6,1,randn(1000,1),zeros(5,1));
debug note: si_dims(0) = 1
octave:3> y = filter(ones(1,6)/6,1,randn(1000,1),zeros(1,5));
debug note: si_dims(0) = 1

3) Octave 3.5.0+ from Mercurial, built a few minutes ago (note the change in
si_dims(0), that's why the code in comment 8 worked for you):

octave:1> version
ans = 3.5.0+
octave:2> y = filter(ones(1,6)/6,1,randn(1000,1),zeros(5,1));
debug note: si_dims(0) = 5
octave:3> y = filter(ones(1,6)/6,1,randn(1000,1),zeros(1,5));
debug note: si_dims(0) = 5

So yes, the new version will have a fixed filter() =). But there are other
things involved, such as the rare behavior over SI (transposed, not
transposed, ???).

I guess it is settled, right?

Thanks again


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?33625>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/