[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #35418] strread.m bugs (missing "; " / undue p
From: |
Philip Nienhuis |
Subject: |
[Octave-bug-tracker] [bug #35418] strread.m bugs (missing "; " / undue parse errors / code cleanup) |
Date: |
Tue, 31 Jan 2012 21:55:30 +0000 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.11) Gecko/20100701 SeaMonkey/2.0.6 |
URL:
<http://savannah.gnu.org/bugs/?35418>
Summary: strread.m bugs (missing ";" / undue parse errors /
code cleanup)
Project: GNU Octave
Submitted by: philipnienhuis
Submitted on: Tue 31 Jan 2012 10:55:29 PM CET
Category: Interpreter
Severity: 3 - Normal
Priority: 5 - Normal
Item Group: Incorrect Result
Status: Patch Submitted
Assigned to: None
Originator Name: Philip Nienhuis
Originator Email:
Open/Closed: Open
Discussion Lock: Any
Release: 3.6.0
Operating System: Any
_______________________________________________________
Details:
1. In some corner cases, strread.m echoed intermediate data due to a missing
";" at L.673.
2. I fixed a few instances where strread didn't adequately check array bounds
in Ls. 442-506. This led to undue messages about "unable to parse file with
given format string").
3. Those instances + a few more (7 in total) contained identical code => I
moved this code elsewhere and replaced it by a boolean flag in the 7
instances.
Indentation in this area fixed as well.
All tests pass (also for textscan & textread)
Patch attached.
(Sorry no changeset, my Windows XP build system got fubarred lately, had to
re-install and I'm still installing loads of SW.)
Suggested text for changeset:
* fixed missing ";"
* fixed array bound checking in lines 442-506
* code cleanup
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Tue 31 Jan 2012 10:55:29 PM CET Name: strread-3.6.0.diff Size: 4kB
By: philipnienhuis
<http://savannah.gnu.org/bugs/download.php?file_id=24945>
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?35418>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Octave-bug-tracker] [bug #35418] strread.m bugs (missing "; " / undue parse errors / code cleanup),
Philip Nienhuis <=