[Octave-bug-tracker] [bug #33765] (FLTK) linestyles not respected for print

[Ben Abbott]

Follow-up Comment #6, bug #33765 (project octave):

Looking at gl-render.cc


$ fgrep -in set_linestyle gl-render.cc
658:  set_linestyle (gridstyle, true);
695:  set_linestyle ("-", true);
892:  set_linestyle ("-", true);
1414:  set_linestyle ("-");
1448:      set_linestyle (props.get_linestyle (), false);
1505:      set_linestyle ("-");
1840:          set_linestyle (props.get_linestyle (), false);
2011:          set_linestyle ("-");
2315:          set_linestyle (props.get_linestyle (), false);
2369:          set_linestyle ("-");
2695:opengl_renderer::set_linestyle (const std::string& s, bool use_stipple)

 
The use_stipple booleans all look backwards to me. I expected something like
below.


658:  set_linestyle (gridstyle, true);
695:  set_linestyle ("-", false);
892:  set_linestyle ("-", false);
1414:  set_linestyle ("-", false);
1448:      set_linestyle (props.get_linestyle (), true);
1505:      set_linestyle ("-", false);
1840:          set_linestyle (props.get_linestyle (), true);
2011:          set_linestyle ("-", false);
2315:          set_linestyle (props.get_linestyle (), true);
2369:          set_linestyle ("-", false);
2695:opengl_renderer::set_linestyle (const std::string& s, bool use_stipple)


Note, that this part of the code is working correctly. What am I missing ?

Also, why not let opengl_renderer::set_linestyle() determine the value for
use_stipple ? Passing the boolean looks redundant to me.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?33765>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/