[Octave-bug-tracker] [bug #35649] fix urlwrite.cc to be backwards compatible with libcurl 7.15.5 for RHEL/CentOS 5

[Rik]

Follow-up Comment #4, bug #35649 (project octave):

I know the usual approach is to test for features rather than versions, but in
this case I thought the approach was acceptable.  First, it is an easy test to
implement.  Second, I don't think this will stay in the Octave code base for
very long.  Octave has minimum requirements for certain external dependencies
like automake, etc.  At some point, Octave will simply declare that it won't
support older versions of libcurl.  I thought this patch could be a temporary
bridge until that point.  The release date for curl-7.17.0, which includes the
functionality we use, was 9/13/2007.  So this September will be 5 years on and
would be a fine time to drop support for earlier curl revisions.

Here is the relevant part of curl.h:


#ifndef CURL_NO_OLDIES /* define this to test if your app builds with all
                          the obsolete stuff removed! */

/* Backwards compatibility with older names */
/* These are scheduled to disappear by 2011 */

/* This was added in version 7.19.1 */
#define CURLOPT_POST301 CURLOPT_POSTREDIR

/* These are scheduled to disappear by 2009 */

/* The following were added in 7.17.0 */
#define CURLOPT_SSLKEYPASSWD CURLOPT_KEYPASSWD
#define CURLOPT_FTPAPPEND CURLOPT_APPEND
#define CURLOPT_FTPLISTONLY CURLOPT_DIRLISTONLY
#define CURLOPT_FTP_SSL CURLOPT_USE_SSL

/* The following were added earlier */

#define CURLOPT_SSLCERTPASSWD CURLOPT_KEYPASSWD
#define CURLOPT_KRB4LEVEL CURLOPT_KRBLEVEL

#else


We could program in a test into configure.ac and undef CURL_NO_OLDIES based on
the results.  However, if the only feature we are using is CURLOPT_FTPLISTONLY
then I think Jordi's solution would be fine.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?35649>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/