[Octave-bug-tracker] [bug #38159] Crashed on calling dicomwrite function

[Michael Goffioul]

Follow-up Comment #5, bug #38159 (project octave):

The bug can be easily identified in dicomwrite.cpp around line 82:

        if (3<args.length()) { // no metadata supplied, need to make some
                try {
                        genMinimalMetaData(&w, file);
                } catch (std::exception) {
                        return retval ;
                }
        } else { // 3rd arg should be struct to turn into metadata
                try {
                        struct2metadata(&w, file, args(2), trial, 0 /* depth of 
indent for SQ
nesting */);
                } catch (std::exception) {
                        return retval ;
                }
        }

The test in the if-statement is inverted. It should probably be: args.length()
< 3

However after fixing that, I get another crash when running:
dicomwrite(rand(10), 'test.dcm')

#0  0x00007fffe324c9d1 in Fdicomwrite (args=..., nargout=0) at
dicomwrite.cpp:110
#1  0x00007ffff68a6f17 in octave_builtin::do_multi_index_op (this=0x10468c0,
nargout=0, args=..., lvalue_list=0x0)


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?38159>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/