[Octave-bug-tracker] [bug #37401] Multi-line command recall is weird in GUI editor; non-GUI is OK.

[Dan Sebald]

Follow-up Comment #5, bug #37401 (project octave):

I see that resizeRequest isn't connected to anything.

[qterminal]$ grep -r resizeRequest *
libqterminal/unix/TerminalModel.h:  void resizeRequest(const QSize& size);
libqterminal/unix/TerminalModel.cpp:    emit resizeRequest(size);

It seems that should be connected to something that configures the _emulation
console so that moving the Qt window changes the size of the _emulation
window.  The emulation is using lines/columns:


  /** Change the size of the emulation's image */
  virtual void setImageSize(int lines, int columns);


but Jacob put some code in the TerminalView


void TerminalView::showResizeNotification()


that computes those values.  So there is at least something partially there to
address that issue.

Are you seeing how when the window is narrowed that the text wraps?  (That's a
Qt window effect, I'm guessing.)  It's odd though.  The keyboard input that is
typed will wrap, but not the text that has already been entered, i.e., up
higher in the window.  Those lines of text will extend past the end of the
screen as through there is no line wrap.

Anyway, as for the missing linefeed, there is a function "receiveData".


void Emulation::receiveData(const char* text, int length)
{
        emit stateSet(NOTIFYACTIVITY);

        bufferedUpdate();
        
        QString unicodeText = _decoder->toUnicode(text,length);


I wonder about that unicode translation.

http://qt-project.org/doc/qt-4.8/qtextdecoder.html

But I took that out and the problem still exists.



    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?37401>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/