[Octave-bug-tracker] [bug #39724] history commands have an extraneous white space at the front

[Dan Sebald]

Follow-up Comment #2, bug #39724 (project octave):

OK.  Thanks for finding that.  The code could even possibly introduce line
numbers, or possibly introduce a * character if the history line is data, not
a command.  Are these some remnant features?  Looking at the "help history",
there is only an option to suppress line numbers (-q), so that would suggest
at one time the default was for line numbers to appear.  Perhaps all these
possible clarifications were deactivated at one time.  It is really only the
commands that the GUI should be displaying.

Perhaps we could ask the list if anyone recalls or sees a reason to keep the
following:


 if (number_lines)
   sprintf (tmp, "%5d%c%s", i + history_base,
            hlist[i]->data ? '*' : ' ',
            line ? line : "");
 else
   sprintf (tmp, "%c%s", hlist[i]->data ? '*' : ' ',
            line ? line : "");


as opposed to just:


   sprintf (tmp, "%s", line ? line : "");


There is something else that should be kept out of the history, in my opinion,
whitespace lines with no command.  In the GUI, try typing spaces and hitting
return.  There are whitespace lines showing up in the history.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?39724>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/