[Octave-bug-tracker] [bug #39864] fir1 - Grid Size versus Filter Order

[Steven Chung]

URL:
  <http://savannah.gnu.org/bugs/?39864>

                 Summary: fir1 - Grid Size versus Filter Order
                 Project: GNU Octave
            Submitted by: stevessr
            Submitted on: Sat 24 Aug 2013 04:06:57 PM GMT
                Category: Octave Function
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Incorrect Result
                  Status: None
             Assigned to: None
         Originator Name: stevessr
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 3.6.4
        Operating System: GNU/Linux

    _______________________________________________________

Details:

*_fir.m_ line-109* hardcodes the *3rd argument of fir2(...) to 512*. The error
occurs when _fir1.m_ is called with its 1st argument 'n' (order of the filter)
to >= 512. The following error is reported:


error: fir2: grid size must be greater than half the filter order
error: called from:
error:   /usr/share/octave/packages/signal-1.2.0/fir2.m at line 89, column 5
error:   /usr/share/octave/packages/signal-1.2.0/fir1.m at line 109, column 3


I believe that the 3rd argument to _fir2(...)_ should be *n+1*. I've installed
this fix and it appears to be working OK.

Many thanks for your time and expertise!





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?39864>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/