[Octave-bug-tracker] [bug #40066] octave-dicom-0.1.1: 5 * off by one error ?

[David Binderman]

URL:
  <http://savannah.gnu.org/bugs/?40066>

                 Summary: octave-dicom-0.1.1: 5 * off by one error ?
                 Project: GNU Octave
            Submitted by: dcb314
            Submitted on: Thu 19 Sep 2013 08:42:32 GMT
                Category: None
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Other
                  Status: None
             Assigned to: None
         Originator Name: David Binderman
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: other
        Operating System: GNU/Linux

    _______________________________________________________

Details:

I just ran the static analysis tool "cppcheck" over
the source code of octave-dicom-0.1.1

It said

[dicomdict.cpp:298]: (error) Width 4 given in format string (no. 1) is larger

than destination buffer 'tgroup[4]', use %3s to prevent overflowing it.
[dicomdict.cpp:298]: (error) Width 4 given in format string (no. 2) is larger

than destination buffer 'telem[4]', use %3s to prevent overflowing it.
[dicomdict.cpp:298]: (error) Width 8 given in format string (no. 3) is larger

than destination buffer 'tvr[8]', use %7s to prevent overflowing it.
[dicomdict.cpp:298]: (error) Width 128 given in format string (no. 4) is
large
r than destination buffer 'key[128]', use %127s to prevent overflowing it.
[dicomdict.cpp:298]: (error) Width 8 given in format string (no. 5) is larger

than destination buffer 'tvm[8]', use %7s to prevent overflowing it.

The count doesn't include the trailing zero byte. Suggest code rework.





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?40066>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/