[Octave-bug-tracker] [bug #36718] moment, skewness, and kurtosis differences with Matlab

[Rik]

Follow-up Comment #21, bug #36718 (project octave):

The patch looks good.  I might change


y(idx) = 3 + C * ((n + 1) * y(idx) - 3 * (n - 1));


to


y = 3 + C * ((n + 1) * y - 3 * (n - 1));


Since it "looks" more like a straightforward equation.  You don't have to
worry about the values not in idx because they have been assigned the value of
NaN, and any further math operation with a NaN value produces a NaN.

Also, this was my mistake in one of the tests for division-by-zero.  I save
and restore the warning state but don't actually force the "divide-by-zero"
state to on.  I've corrected that in skewness so that the test reads


## Verify no "divide-by-zero" warnings
%!test
%! wstate = warning ("query", "Octave:divide-by-zero");
%! warning ("on", "Octave:divide-by-zero");
%! unwind_protect
%!   lastwarn ("");  # clear last warning
%!   skewness (1);
%!   assert (lastwarn (), "");
%! unwind_protect_cleanup
%!   warning (wstate, "Octave:divide-by-zero");
%! end_unwind_protect



    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?36718>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/