[Octave-bug-tracker] [bug #39314] convn(x, y, "valid") produces results that are different from Matlab

[Carnë Draug]

Follow-up Comment #19, bug #39314 (project octave):

If the fix is indeed to re-reverse the order of the summation, then the fix
may involve reverting the following changesets:

http://hg.savannah.gnu.org/hgweb/octave/rev/1094868ca10d


changeset:   10946:1094868ca10d
user:        Jaroslav Hajek <address@hidden>
date:        Tue Sep 07 12:23:01 2010 +0200
summary:     fix bugs in inner convolution


http://hg.savannah.gnu.org/hgweb/octave/rev/ad1d7a53b1ca


changeset:   14596:ad1d7a53b1ca
branch:      stable
parent:      14590:6250e1232c9c
user:        Sunghyun Cho <address@hidden>
date:        Tue Apr 17 12:47:34 2012 +0100
summary:     perform convolution properly independently of matrix orientation
(bug #34893)


I'm unsure why reverting it was required. I may be recalling wrong, but I
think simply adding an extra offset when passing the pointers to convolve_nd
should be enough. This would avoid having a separate routine for the valid
shape, and possibly speed-up the shape "same" which is currently implemented
as computing the "full" shape and then clipping the borders.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?39314>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/