octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #40581] Fix using uninitialised variables as p


From: Rik
Subject: [Octave-bug-tracker] [bug #40581] Fix using uninitialised variables as parameter in __init_fltk__.cc (pixel2status)
Date: Sun, 17 Nov 2013 23:45:10 +0000
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:25.0) Gecko/20100101 Firefox/25.0

Update of bug #40581 (project octave):

                  Status:                    None => Fixed                  
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #1:

I applied your changeset here
(http://hg.savannah.gnu.org/hgweb/octave/rev/265f9186e543).  I modified it
slightly.  Octave's convention is not to do simultaneous declaration and
initialization of variables for more than one variable on a line.  So,


double x0 = 0;


is good, but

double x0 = 0, y0 = 0;


is discouraged.  To solve this I just broke up the declaration and
initialization into two lines.

Secondly, I used the value NaN, rather than 0, to reflect the fact the value
is unknown, rather than known to be 0.

Thanks for catching this imperfect code.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?40581>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]