[Octave-bug-tracker] [bug #40894] unrecognised block comments in dos format saved files

[John W. Eaton]

Follow-up Comment #2, bug #40894 (project octave):

We currently have two patterns to match comments in the lexer.  They appear in
the following order:


^{S}*{CCHAR}\{{S}*{NL}  --> block comment start
{S}*{CCHAR}.*{NL}       --> line comment start


The flex docs say that when two patterns match and the text that they match is
the same length, then the action that is used is supposed to be the one
corresponding to the pattern that appears first in the lex input file.  So
unless I'm missing something, I think this may be a bug in flex.  But it looks
like we can also work around the problem with the attached patch.  Please test
it and let me know if it solves the problem for you.

I suppose that we should apply this change to the stable branch since block
comments won't work for files with CRLF line endings and that seems like a
fairly serious and obvious problem that will probably affect a lot of people. 
Does anyone object to making the change on the stable branch?



(file #29916)
    _______________________________________________________

Additional Item Attachment:

File name: diffs.txt                      Size:3 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?40894>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/