[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #41560] Typo in jit-typeinfo.cc
|
From: |
David Malcolm |
|
Subject: |
[Octave-bug-tracker] [bug #41560] Typo in jit-typeinfo.cc |
|
Date: |
Wed, 12 Feb 2014 17:15:20 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.22 (KHTML, like Gecko) Chrome/25.0.1364.172 Safari/537.22 |
Follow-up Comment #2, bug #41560 (project octave):
FWIW, I think the issue was more serious: the parameter was passed as the 2nd
param to register_intrinsic, aka "iid":
http://hg.savannah.gnu.org/hgweb/octave/file/634d9989bf7b/libinterp/corefcn/jit-typeinfo.cc#l2047
where it gets converted to :
llvm::Intrinsic::ID id = static_cast<llvm::Intrinsic::ID> (iid);
and then used in this call:
llvm::Function *ifun = llvm::Intrinsic::getDeclaration (module, id,
llvm_args);
Hence I believe that calls to "exp" were being erroneously jit-compiled to
"cos" calls, thus silently giving the wrong answers.
That said, your fix in 634d9989bf7b looks good; thanks!
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?41560>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/