[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #41776] Function unitsratio giving incorrect r
From: |
Felipe G. Nievinski |
Subject: |
[Octave-bug-tracker] [bug #41776] Function unitsratio giving incorrect result for unitsratio("degree", "radian") |
Date: |
Wed, 05 Mar 2014 07:27:22 +0000 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/33.0.1750.117 Safari/537.36 |
Follow-up Comment #1, bug #41776 (project octave):
there's a typo in line 59:
valid_to = validatestring (from, {"radians", "degrees"});
compare it to line 60:
valid_from = validatestring (from, {"radians", "degrees"});
do you see it?
can you please work on a patch?
also please enable and correct the following tests:
%!assert (unitsratio ("degrees", "radians"), 180 / pi)
%!assert (unitsratio ("radians", "degrees"), pi / 180)
the true values seem to be switched between first and second assert.
thanks.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?41776>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [Octave-bug-tracker] [bug #41776] Function unitsratio giving incorrect result for unitsratio("degree", "radian"), Arpit Sharma, 2014/03/05
- [Octave-bug-tracker] [bug #41776] Function unitsratio giving incorrect result for unitsratio("degree", "radian"), John W. Eaton, 2014/03/05
- [Octave-bug-tracker] [bug #41776] Function unitsratio giving incorrect result for unitsratio("degree", "radian"),
Felipe G. Nievinski <=
- [Octave-bug-tracker] [bug #41776] Function unitsratio giving incorrect result for unitsratio("degree", "radian"), Arpit Sharma, 2014/03/06
- [Octave-bug-tracker] [bug #41776] Function unitsratio giving incorrect result for unitsratio("degree", "radian"), Arpit Sharma, 2014/03/06
- [Octave-bug-tracker] [bug #41776] Function unitsratio giving incorrect result for unitsratio("degree", "radian"), Carnë Draug, 2014/03/06
- [Octave-bug-tracker] [bug #41776] Function unitsratio giving incorrect result for unitsratio("degree", "radian"), Carnë Draug, 2014/03/06
- [Octave-bug-tracker] [bug #41776] Function unitsratio giving incorrect result for unitsratio("degree", "radian"), Felipe G. Nievinski, 2014/03/06
- [Octave-bug-tracker] [bug #41776] Function unitsratio giving incorrect result for unitsratio("degree", "radian"), Carnë Draug, 2014/03/06
- [Octave-bug-tracker] [bug #41776] Function unitsratio giving incorrect result for unitsratio("degree", "radian"), Felipe G. Nievinski, 2014/03/06
- [Octave-bug-tracker] [bug #41776] Function unitsratio giving incorrect result for unitsratio("degree", "radian"), Carnë Draug, 2014/03/06