[Octave-bug-tracker] [bug #41965] __makeinfo__ assumes unsigned char for input text when it should be signed char

[Mike Miller]

Update of bug #41965 (project octave):

                  Status:               Confirmed => Patch Submitted        
             Assigned to:                    None => mtmiller               

    _______________________________________________________

Follow-up Comment #2:

In writing to the continuing thread on the mailing list, I just realized an
even better solution for this that is *not* a workaround, simply use fprintf
when dealing with human-readable text, both for consistency and to let the
appropriate library routine deal with the conversion.

So the diff should be


-    fwrite (fid, text);
+    fprintf (fid, "%s", text);


I'll test this later and commit (away from dev box at the moment, if someone
else is interested feel free to take care of this). This seems safe enough
that it should work on the stable branch.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?41965>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/