[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #42307] Play button does not run script if nam
|
From: |
Jordi Gutiérrez Hermoso |
|
Subject: |
[Octave-bug-tracker] [bug #42307] Play button does not run script if name contains hyphen |
|
Date: |
Tue, 06 May 2014 18:46:31 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:28.0) Gecko/20100101 Firefox/28.0 Iceweasel/28.0 |
Follow-up Comment #2, bug #42307 (project octave):
cset 770c525a1a2b doesn't quite address this bug, does it? I mean, even if
there is a warning about the script name not being a valid identifier, there's
no reason why the GUI should be nagging with pop-ups about this after the fact
(I also expect many users will be confused by what "is not a valid identifier"
means). The warning is more for the case about trying to run the script from
the CLI. Also, this allows for a Octave shell injection in case someone
creates a filename with quotes
Can't we just avoid attempting to parse the filename at all and instead
directly call Fsource from as defined from libinterp/builtin-defun-decls.h
from the build directory? Does the octave-link class allow this? Part of the
idea of tying the GUI tightly with Octave is so that we could directly use
Octave's general C++ API from the GUI.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?42307>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/