octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #39495] polar plot should have a circular rho/


From: Rik
Subject: [Octave-bug-tracker] [bug #39495] polar plot should have a circular rho/theta axis
Date: Wed, 25 Jun 2014 22:01:51 +0000
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:30.0) Gecko/20100101 Firefox/30.0

Follow-up Comment #13, bug #39495 (project octave):

The patch is almost there.  Changes I see

1) Re-instate 


lim = 1.1 * rtick(end);


because the labels at 0 and 180 are not visible without this.

2) Use double quotes rather than single quotes.  For example, "xlim" rather
than 'xlim' as this is the Octave coding convention.

3) For unused arguments use the ignored variable syntax of "~".  For example 


function resetaxis (cax, d, ax, orig_props)
=>
function resetaxis (~, ~, hax)


4) get (gca, 'xlim') is bound to return something.  I think you can remove the
if test that has a comment on it.


if (! isempty (oldxlim))   ## can xlim be empty?


5) Use hax, instead of ax, in the resetaxis routine to mirror what is used at
the start of the function with all of the addlistener calls.

6) Remove copy/paste comment


## FIXME: Probably don't want to delete everyone's listeners on colormap.




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?39495>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]