[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #42307] Play button does not run script if nam
|
From: |
Jordi Gutiérrez Hermoso |
|
Subject: |
[Octave-bug-tracker] [bug #42307] Play button does not run script if name contains hyphen |
|
Date: |
Wed, 22 Oct 2014 19:07:57 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 Iceweasel/32.0.3 |
Follow-up Comment #6, bug #42307 (project octave):
Nice, so it really is possible to call Fsource. Now, for a bit of code
review...
* I don't very much like the switch statement on cmd_type. Seems to me like
this is what polymorphic dispatch is for. If you do go for polymorphism, then
the cmd_info struct would have to become octave_cmd or something like it. This
might break API too much and be too much of a pain, and since I'm not the one
writing the code, I don't get to make this decision.
* I never like bare pointers. Does _cmd_queue really have to be a bare
pointer? I know this is not really part of this change, just noticed it now.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?42307>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/