octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #42764] squareform in statistics package retur


From: JD Walsh
Subject: [Octave-bug-tracker] [bug #42764] squareform in statistics package returns column vector, Matlab returns row vector
Date: Sun, 09 Nov 2014 12:20:53 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:33.0) Gecko/20100101 Firefox/33.0 Iceweasel/33.0

Follow-up Comment #3, bug #42764 (project octave):

Sorry about that! Just before patching, I reverted the code to what I
*thought* was an earlier version (after testing on MatLab showed that
`squareform' should accept both row and column vectors as arguments). I should
have retested to make sure all was well.

I ran multiple tests, and ended up rewriting two argument checking lines to
use built-in Octave routines (`isnumeric' and `issymmetric'). The rewritten
lines should run faster and be easier to maintain. I've attached a new patch
`squareform2' with these changes.

(file #32394)
    _______________________________________________________

Additional Item Attachment:

File name: squareform2.patch              Size:6 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?42764>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]