[Octave-bug-tracker] [bug #43691] findpeaks: "extra" undefined if no peak matches criteria

[Andreas Weber]

URL:
  <http://savannah.gnu.org/bugs/?43691>

                 Summary: findpeaks: "extra" undefined if no peak matches
criteria
                 Project: GNU Octave
            Submitted by: andy1978
            Submitted on: Di 25 Nov 2014 09:08:43 GMT
                Category: Octave Forge Package
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Incorrect Result
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: dev
        Operating System: GNU/Linux

    _______________________________________________________

Details:

signal-1.3.0:


octave:1> data = [0; 2; 5; 6; 5; 2; 0];
octave:2> [PKS, LOC, EXTRA] = findpeaks (data, "MinPeakWidth", 3)
error: 'extra' undefined near line 253 column 19
error: called from:
error:   /home/andy/octave/signal-1.3.0/findpeaks.m at line 253, column 17


this is because in findpeaks.m:225, "extra" is never populated if not even one
peak matches the MinPeakWidth, MinPeakHeight... criterias. I think extra
should returns just an empty struct in this case.

Btw, if the peaks are detected I get

warning: operator -: automatic broadcasting operation applied
warning: called from
    findpeaks at line 153 column 5


from


  ## Treat peaks separated less than minD as one
  D = abs (idx_s - idx_s');


I would suggest using bsxfun (@minus, idx_s, idx_s') if this is intended.





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?43691>

_______________________________________________
  Nachricht gesendet von/durch Savannah
  http://savannah.gnu.org/