[Octave-bug-tracker] [bug #43305] Hamming etc. windows are wrong

[Doug Stewart]

Follow-up Comment #4, bug #43305 (project octave):

Oscar stated:

"
So rather than host an argument on this list, this is what I propose: Do what
Matlab** and SciPy*** **** do. Acknowledge both uses by making a flag to
handle the “periodic” or the “symmetric” cases. The Matlab default is
“symmetric” which is of course unfortunate but at least such inclusion in
Octave and SciPy would retain compatibility with the existing usage. Then
it’s up to the user whether to shoot him/herself in the foot, assuming that
such a decision is guided by actually referring to the documentation for the
package being used, since the default behavior is wrong.
"

So each window function now has 1 input  (length)

1) Should we now have 2 inputs  (length , type) 
   where  type =  “periodic” or “symmetric”
   Which should be the default?

2) What length do we want?
   example:
     length =8
     Should we produce 8 for both periodic and symmetrical?
     or 7 for periodic and 8 for symmetrical
    8 for symmetrical is what we do now and would have to stay
    that way for compatibility with our old way and with Matlab.
     If we did 7 then the actual numbers would be the same
     between the 2 methods. With 8 the numbers are different.
  My preference is 8 for both.  


Mike what are your thoughts?

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?43305>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/