[Octave-bug-tracker] [bug #43959] statistics package: kmeans incompatibility with Matlab

[Lachlan Andrew]

Follow-up Comment #7, bug #43959 (project octave):

Greetings Jordi,

I've noticed that the three patches I submitted earlier don't play nicely
together.  Sorry for being so careless...

Here is a patch that fixes those three issues, and a whole lot of other issues
with  kmeans.m

1. Implement "distance", "maxiter" options
2. Implement "erroraction=drop".
3. Fix bug in "erroraction=singleton" (It used to re-assign the last sample,
rather than the sample furthest from its centroid.)
4. Implement explicit initialization for "start"; give warning for
unimplemented arguments for "start", and drop back to "sample".
5. Give errors when invalid options are supplied, and warnings when valid but
unimplemented options are supplied.
6. Don't crash if an odd number of arguments is supplied.

I tried to follow all of the coding standards you mentioned.  I tried to use
explicit forms of "end", but it seems "endtry" is not valid.  Is that
intentional?

Since this changes almost every line of code, I took the liberty of listing
myself at the top in the list of authors.  However, I'm happy for you to
remove that.

If you are happy with this, I'll create the commit log entry.

Thanks,
Lachlan

(file #32934)
    _______________________________________________________

Additional Item Attachment:

File name: kmeans.allpatch                Size:10 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?43959>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/