[Octave-bug-tracker] [bug #43769] error: invalid meta.package indexing when using strfind function

[Michael Goffioul]

Follow-up Comment #8, bug #43769 (project octave):

No there is no reason. I believe the reason I made load_path::get_loader to
create loader on-demand is to support methods like load_path::add,
load_path::move or load_path::remove.

I'm wondering whether your last patch may have a non-negligible performance
impact, as you'll iterate over dir_info_list and a search in package_dir_map
when doing symbol lookup (get_loader being used by methods like
load_path::find_fcn).

Maybe another possible approach is to add a bool argument to
load_path::get_loader to enable auto-insertion, set to false by default. Then
set that argument to true explicitly in the calls where auto-insertion is
required (mainly in load_path::add, load_path::move and load_path::remove).


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?43769>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/