octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #44776] [Qt] Restore window button does not tr


From: Dan Sebald
Subject: [Octave-bug-tracker] [bug #44776] [Qt] Restore window button does not trigger a repaint event for its content
Date: Thu, 09 Apr 2015 02:15:29 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:18.0) Gecko/20100101 Firefox/18.0 SeaMonkey/2.15

Follow-up Comment #7, bug #44776 (project octave):

The long shot fixes the problem.  Well, sort of.  It ends up doing a double
draw most of the time which doesn't look so nice - similar to what's under
discussion here:

https://savannah.gnu.org/bugs/index.php?44781

Couple comments about this construct:


      if (d->m_internal)
        emit d->m_figure->asyncUpdate ();


Emitting a signal usually doesn't need a conditional.  Instead, making a
connection or not making a connection accomplishes the same thing.  That is,
emit mySignal () won't do anything if there is nothing connected to it.  Also,
although technically nothing is wrong with emitting a signal belonging to
another object and I've not read anything that discourages it, my thought is
why not make the signal part of the object, i.e., Figure:asynchUpdate()?  The
advantage is not having additional variables to keep track of externals.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?44776>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]