[Octave-bug-tracker] [bug #44485] GUI: File | Exit from main menu doesn't work when Octave is busy

[Dan Sebald]

Follow-up Comment #25, bug #44485 (project octave):

I'm checking here occasionally and still have this feature in the back of my
mind, but I've very limited on time at the moment.

Here's a new patch with a new approach.  Rather than attempt to make QThread
exit gracefully and/or try to change the Octave interpreter's signal handling
(something I really don't want to change, no less before a release), let's try
to use the interpreter's existing mechanism for aborting the program: Cntrl-C
three times in a row.

In the attached patch I've done a forced exit by issuing four Cntrl-Cs in a
row.  The first one won't contribute to "three-in-a-row" if it properly
interrupts out of a process.  So, using the forced exit, I'm hoping the worst
you see is the same as what is seen at the command line:


octave:1> inv(rand(10000))
^C^CPress Control-C again to abort.
^Cpanic: Interrupt -- stopping myself...
attempting to save variables to 'octave-workspace'...
save to 'octave-workspace' complete


I also changed the wait time to 2.0 seconds rather than 3.0.

I'm OK with the Cntrl-C abort approach, but I'm still not 100% sure of the
flow is just right.  The one issue I see right now is if during forced exit
and confirmation on open files the original "exit" gets processed and one
"Cancel"s the exit via file-save, another immediate file-save confirmation
will be attempted.

I will think about "double confirm" issue one a bit, but in mean time, please
try this patch and see if it works better for you.

(file #33994)
    _______________________________________________________

Additional Item Attachment:

File name: octave-exit_timer-djs2015may12.patch Size:6 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?44485>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/