[Octave-bug-tracker] [bug #45196] gallery: raises error when calling randsvd, pei, kms, hanowa, gearmat.

[Carnë Draug]

Follow-up Comment #5, bug #45196 (project octave):

Looking at the repository now, it seems like you had one commit (your first
patch here that got rejected).  Then you made a new commit to backout.  Then
you made two commits on top of that. You don't do it that way.

If your commit gets rejected, you update your working directory to the
previous changeset and make a new commit there.  This will create a new head. 
You can then either delete the other commits completely or let them be
forgotten.  You should also keeo that repository up to date.  You haven't
pulled any changes in the last 4 weeks (I'm guessing since you cloned it).

On the actual review of you changeset:

Please put the tests back, they are not unnecessary. But write proper tests,
they are easy to write.  If, for example, you call 'gallery ("clement", 5)',
it has a single outcome.  Other cases such as rando or randhess are tricker
but you can still write tests for their properties.  At the very least, you
could test that the returned matrix is of the right size (but please don't
test this only).



    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?45196>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/